retina icon indicating copy to clipboard operation
retina copied to clipboard

fix #239: Include protocol labels in advanced metrics

Open andreev-io opened this issue 1 year ago • 4 comments

Description

Allow grouping time series by a complete L4 packet 5-tuple by adding a protocol label to advanced metrics.

Related Issue

https://github.com/microsoft/retina/issues/239

Checklist

  • [x] I have read the contributing documentation.
  • [ ] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [ ] I have correctly attributed the author(s) of the code.
  • [ ] I have tested the changes locally.
  • [ ] I have followed the project's style guidelines.
  • [ ] I have updated the documentation, if necessary.
  • [ ] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

andreev-io avatar Apr 08 '24 14:04 andreev-io

@microsoft-github-policy-service agree company="Microsoft"

andreev-io avatar Apr 08 '24 15:04 andreev-io

@microsoft-github-policy-service agree company="Microsoft"

@andreev-io this should say company="your companyname" i.e. company="ClickHouse"

Also, this approach looks good to me, do we need to add this same protocol flag to other metrics modules as well ?

vakalapa avatar Apr 10 '24 16:04 vakalapa

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar May 11 '24 00:05 github-actions[bot]

hey @andreev-io will you be finishing this? is #239 still relevant?

rbtr avatar May 14 '24 16:05 rbtr

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar Jun 14 '24 00:06 github-actions[bot]

Pull request closed due to inactivity.

github-actions[bot] avatar Jun 22 '24 00:06 github-actions[bot]