retina icon indicating copy to clipboard operation
retina copied to clipboard

fix: failed to initialize filter map

Open wenhuwang opened this issue 1 year ago • 3 comments

Description

fixes: #153

Testing Done

  1. Built amd64 image and deployed them in a K8s cluster
  2. agent pod is up and running

wenhuwang avatar Mar 28 '24 09:03 wenhuwang

@wenhuwang can you sign your commit please? git commit -S -s --amend --no-edit && git push -f should do it 🙂

rbtr avatar Mar 29 '24 21:03 rbtr

@wenhuwang can you sign your commit please? git commit -S -s --amend --no-edit && git push -f should do it 🙂

@rbtr thank you, have done.

wenhuwang avatar Mar 30 '24 08:03 wenhuwang

Hey @wenhuwang, I see a signed commit now but there are other commits on the branch that are unsigned. Unfortunately those are still preventing merge. If you can squash to a single commit or sign them all, we can complete this 🙂

Sorry about the difficulty here. I've opened issue #197 for improving the contributing docs with our signed/signed-off requirements

rbtr avatar Mar 30 '24 15:03 rbtr

@rbtr hello,it should be fine now?

wenhuwang avatar Mar 31 '24 08:03 wenhuwang

thanks @wenhuwang! this will be in v0.0.5

rbtr avatar Mar 31 '24 21:03 rbtr