retina icon indicating copy to clipboard operation
retina copied to clipboard

fix(grafana): repair node selection & metrics name

Open aslafy-z opened this issue 1 year ago • 7 comments

  • Update 'dns' & 'clusters' Grafana dashboards to fix node selection
  • Update 'pod-level' Grafana dashboard to fix metrics names, pod selection and datasource templating
  • Update datasource variable to DS_PROMETHEUS convention

Note: The pod-level grafana dashboard still have some old metrics to update.

aslafy-z avatar Mar 27 '24 15:03 aslafy-z

@huntergregory to review.

vakalapa avatar Mar 27 '24 15:03 vakalapa

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

Please have a look @vakalapa @huntergregory @rbtr

aslafy-z avatar May 03 '24 01:05 aslafy-z

hey @aslafy-z, thanks for working on this fix. I see that you have the DCO "signed-off-by" on all your commits, but we also need a cryptographic sig to be able to guarantee origin. Would you update these with a signature? Here's how: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits I'm looking for this "Verified" tag commits in the PR once you've done that: image

rbtr avatar May 03 '24 16:05 rbtr

@rbtr I just rebased, squashed and signed my commits :)

aslafy-z avatar May 03 '24 18:05 aslafy-z

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar Jun 04 '24 00:06 github-actions[bot]

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar Jul 07 '24 00:07 github-actions[bot]

This PR will be closed in 7 days due to inactivity.

github-actions[bot] avatar Sep 07 '24 00:09 github-actions[bot]

Pull request closed due to inactivity.

github-actions[bot] avatar Sep 14 '24 00:09 github-actions[bot]

@rbtr @huntergregory @cmergenthaler My priorities are shifting, I'm now working on another project without any Azure clusters on hand. Feel free to take over if you're able.

aslafy-z avatar Sep 26 '24 16:09 aslafy-z

@ibezrukavyi

rbtr avatar Sep 26 '24 16:09 rbtr