retina icon indicating copy to clipboard operation
retina copied to clipboard
verified publisher icon microsoft

fix: Refactor usages of unsafe

Open Troy-Butler opened this issue 1 year ago • 4 comments

Addresses issue #95

Troy-Butler avatar Mar 21 '24 20:03 Troy-Butler

@anubhabMajumdar are you willing to take this now that E2E is running?

rbtr avatar Mar 29 '24 22:03 rbtr

@anubhabMajumdar are you willing to take this now that E2E is running?

@Troy-Butler Can you update the description with testing done for advanced mode and paste the advanced TCP metrics generated? Either local or remote context would work. This would ensure your code changes are tested. Thanks!

anubhabMajumdar avatar Apr 01 '24 14:04 anubhabMajumdar

@anubhabMajumdar are you willing to take this now that E2E is running?

@Troy-Butler Can you update the description with testing done for advanced mode and paste the advanced TCP metrics generated? Either local or remote context would work. This would ensure your code changes are tested. Thanks!

Please forgive my ignorance, this is my first contribution to this project. What do I need to run to generate the metrics you need?

Troy-Butler avatar Apr 02 '24 11:04 Troy-Butler

@anubhabMajumdar are you willing to take this now that E2E is running?

@Troy-Butler Can you update the description with testing done for advanced mode and paste the advanced TCP metrics generated? Either local or remote context would work. This would ensure your code changes are tested. Thanks!

Please forgive my ignorance, this is my first contribution to this project. What do I need to run to generate the metrics you need?

Apologies, I should have included the instructions. Here's how you can get started:

  • Build container image with your changes - https://retina.sh/docs/contributing/#build
  • Deploy in advance mode - https://retina.sh/docs/installation/setup#advanced-mode-with-local-context-with-capture-support
  • Check the *adv_* metrics - https://retina.sh/docs/contributing/#metrics

Another way to quickly test a single plugin on your host machine (in your case that would be Packetparser) would be this - https://retina.sh/docs/contributing/#build (look for To build binary of a plugin and test it).

Here's the corresponding main file you need to run - https://github.com/microsoft/retina/blob/main/test/plugin/packetparser/main_linux.go . You would also need to build and run - https://github.com/microsoft/retina/tree/main/init/retina .

Let me know if you need any help, would be happy to help! Thanks again for your contribution.

anubhabMajumdar avatar Apr 03 '24 13:04 anubhabMajumdar