retina icon indicating copy to clipboard operation
retina copied to clipboard

add kernel version to telemetry traces.

Open jimassa opened this issue 1 year ago • 6 comments

heartbeat already comes with kernel version attribute; https://github.com/microsoft/retina/blob/5ff1567e8a988209494b0cddd34f3939ac51e53c/pkg/telemetry/telemetry.go#L170

We would like to add it to traces as well in order to directly pinpoint what kernel version is producing a specific log.

jimassa avatar Nov 26 '24 13:11 jimassa

Hi @jimassa, I would like to contribute to this

Anirudh2112 avatar Nov 27 '24 17:11 Anirudh2112

Hello @jimassa I have made the necessary changes and committed a PR. Kindly review it. Thank you.

Anirudh2112 avatar Dec 02 '24 17:12 Anirudh2112

isn't it possible to correlate pod name with kernel version in heartbeat?

matmerr avatar Dec 02 '24 17:12 matmerr

Thank you for the suggestion! I will add the pod name to the heartbeat properties to enable correlation with the kernel version. I'll update the PR shortly. Please let me know if there are any other changes/features to be implemented.

Anirudh2112 avatar Dec 02 '24 17:12 Anirudh2112

podname should already be a part of telemetry properties, so it should be all good

https://github.com/microsoft/retina/blob/8963dd561d4d5b52c1f711dcbc13fe9f616bd360/pkg/telemetry/telemetry.go#L155

matmerr avatar Dec 02 '24 18:12 matmerr

Yes, In the TrackEvent method, t.properties is merged with the provided event properties, so podname will automatically be included in the heartbeat telemetry.

Anirudh2112 avatar Dec 02 '24 18:12 Anirudh2112