responsible-ai-toolbox icon indicating copy to clipboard operation
responsible-ai-toolbox copied to clipboard

[WIP] use pool for WSGIServer to ensure all greenlets exit to fix flaky flask tests

Open imatiach-msft opened this issue 2 years ago • 9 comments
trafficstars

Description

Use pool for WSGIServer to ensure all greenlets exit to fix flaky flask testsAttempting to reduce flaky flask tests.

Checklist

  • [ ] I have added screenshots above for all UI changes.
  • [ ] I have added e2e tests for all UI changes.
  • [ ] Documentation was updated if it was needed.

imatiach-msft avatar Jan 04 '23 17:01 imatiach-msft

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 04 '23 18:01 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 15:01 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 15:01 github-actions[bot]

Codecov Report

Merging #1877 (dd4d157) into main (e944dc5) will decrease coverage by 9.45%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
- Coverage   92.44%   82.98%   -9.46%     
==========================================
  Files         103       39      -64     
  Lines        4830      776    -4054     
==========================================
- Hits         4465      644    -3821     
+ Misses        365      132     -233     
Flag Coverage Δ
unittests 82.98% <100.00%> (-9.46%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rai_core_flask/rai_core_flask/flask_helper.py 100.00% <100.00%> (+4.61%) :arrow_up:
...ibleai/_tools/shared/state_directory_management.py
...sibleai/responsibleai/rai_insights/rai_insights.py
responsibleai/responsibleai/_internal/__init__.py
...onsibleai/responsibleai/managers/causal_manager.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
erroranalysis/erroranalysis/analyzer/__init__.py
...ibleai/responsibleai/managers/explainer_manager.py
...eai/responsibleai/databalanceanalysis/constants.py
...sibleai/responsibleai/_tools/shared/base_result.py
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jan 06 '23 15:01 codecov-commenter

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 15:01 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 16:01 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 16:01 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 20:01 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/fix-flaky-flask-tests/dashboard/index.html

github-actions[bot] avatar Jan 06 '23 20:01 github-actions[bot]