responsible-ai-toolbox icon indicating copy to clipboard operation
responsible-ai-toolbox copied to clipboard

remove the unnecessary dependency pins in nlp-feature-extractors package

Open imatiach-msft opened this issue 3 years ago • 4 comments

Description

Remove the unnecessary dependency pins in nlp-feature-extractors package. The pin on tqdm caused issues with other dependencies during image create, even though it is completely unnecessary (there is no specific API used which needs a particular version, it's using the most basic functionality to create the status bar). The pins are unnecessary and create a lot of dependency issues with other packages. Also removing protobuf as it's not needed at all anywhere.

Checklist

  • [ ] I have added screenshots above for all UI changes.
  • [ ] I have added e2e tests for all UI changes.
  • [ ] Documentation was updated if it was needed.

imatiach-msft avatar Oct 03 '22 14:10 imatiach-msft

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/rm-hard-pins-nlp/dashboard/index.html

github-actions[bot] avatar Oct 03 '22 15:10 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/rm-hard-pins-nlp/dashboard/index.html

github-actions[bot] avatar Oct 03 '22 15:10 github-actions[bot]

Codecov Report

Merging #1759 (01b9348) into main (cbb4289) will increase coverage by 0.42%. The diff coverage is n/a.

:exclamation: Current head 01b9348 differs from pull request most recent head df6d26b. Consider uploading reports for the commit df6d26b to get more accurate results

@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   88.30%   88.72%   +0.42%     
==========================================
  Files          89       70      -19     
  Lines        5250     4844     -406     
==========================================
- Hits         4636     4298     -338     
+ Misses        614      546      -68     
Flag Coverage Δ
unittests 88.72% <ø> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rai_core_flask/rai_core_flask/flask_helper.py
..._flask/environments/credentialed_vm_environment.py
raiutils/raiutils/models/model_utils.py
..._core_flask/rai_core_flask/environment_detector.py
.../raiutils/data_processing/data_processing_utils.py
raiutils/raiutils/webservice/webservice.py
raiutils/raiutils/common/retries.py
raiutils/raiutils/models/__init__.py
...ai_core_flask/environments/azure_nb_environment.py
raiutils/raiutils/dataset/__init__.py
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 03 '22 15:10 codecov-commenter

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/rm-hard-pins-nlp/dashboard/index.html

github-actions[bot] avatar Oct 03 '22 20:10 github-actions[bot]