responsible-ai-toolbox icon indicating copy to clipboard operation
responsible-ai-toolbox copied to clipboard

in error analysis, refactor error rate metric into function

Open imatiach-msft opened this issue 3 years ago • 2 comments

Description

In erroranalysis package, refactor the error rate metric computation into a function, to make it more similar to other metrics.

Checklist

  • [ ] I have added screenshots above for all UI changes.
  • [ ] I have added e2e tests for all UI changes.
  • [ ] Documentation was updated if it was needed.

imatiach-msft avatar Sep 23 '22 21:09 imatiach-msft

Codecov Report

Merging #1742 (d93ceb5) into main (6d46af4) will increase coverage by 0.00%. The diff coverage is 84.61%.

@@           Coverage Diff           @@
##             main    #1742   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files          96       96           
  Lines        5481     5490    +9     
=======================================
+ Hits         4853     4861    +8     
- Misses        628      629    +1     
Flag Coverage Δ
unittests 88.54% <84.61%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
erroranalysis/erroranalysis/_internal/metrics.py 88.67% <77.77%> (-2.23%) :arrow_down:
...is/erroranalysis/_internal/surrogate_error_tree.py 88.17% <100.00%> (+0.31%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 23 '22 21:09 codecov-commenter

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/refactor-ea-err-metric/dashboard/index.html

github-actions[bot] avatar Sep 23 '22 21:09 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/refactor-ea-err-metric/dashboard/index.html

github-actions[bot] avatar Dec 01 '22 22:12 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/refactor-ea-err-metric/dashboard/index.html

github-actions[bot] avatar Dec 02 '22 16:12 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/refactor-ea-err-metric/dashboard/index.html

github-actions[bot] avatar Dec 02 '22 17:12 github-actions[bot]