responsible-ai-toolbox
responsible-ai-toolbox copied to clipboard
Simplify route generation logic for testing with flights
Description
So far, we used the string "noFlights"
to avoid providing an empty string that the route generation can't handle which is not ideal. Instead, this PR removes the flighting portion of the route if we don't select flights. This significantly simplifies the logic overall.
I'm also making model-assessment the default option in the test env, meaning I have to update the snapshot.
Checklist
- [ ] I have added screenshots above for all UI changes.
- [ ] I have added e2e tests for all UI changes.
- [ ] Documentation was updated if it was needed.
Codecov Report
Merging #1530 (d190139) into main (5fe8a91) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #1530 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 96 96
Lines 5481 5481
=======================================
Hits 4853 4853
Misses 628 628
Flag | Coverage Δ | |
---|---|---|
unittests | 88.54% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html