responsible-ai-toolbox icon indicating copy to clipboard operation
responsible-ai-toolbox copied to clipboard

Simplify route generation logic for testing with flights

Open romanlutz opened this issue 2 years ago • 12 comments

Description

So far, we used the string "noFlights" to avoid providing an empty string that the route generation can't handle which is not ideal. Instead, this PR removes the flighting portion of the route if we don't select flights. This significantly simplifies the logic overall.

I'm also making model-assessment the default option in the test env, meaning I have to update the snapshot.

Checklist

  • [ ] I have added screenshots above for all UI changes.
  • [ ] I have added e2e tests for all UI changes.
  • [ ] Documentation was updated if it was needed.

romanlutz avatar Jul 01 '22 05:07 romanlutz

Codecov Report

Merging #1530 (d190139) into main (5fe8a91) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files          96       96           
  Lines        5481     5481           
=======================================
  Hits         4853     4853           
  Misses        628      628           
Flag Coverage Δ
unittests 88.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 01 '22 05:07 codecov-commenter

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 01 '22 06:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 01 '22 16:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 01 '22 16:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 01 '22 21:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 06 '22 00:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 06 '22 00:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 08 '22 22:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 12 '22 19:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 13 '22 19:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 14 '22 19:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Jul 14 '22 20:07 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Nov 29 '22 10:11 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Nov 30 '22 20:11 github-actions[bot]

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/test_simplification/dashboard/index.html

github-actions[bot] avatar Nov 30 '22 20:11 github-actions[bot]