responsible-ai-toolbox
responsible-ai-toolbox copied to clipboard
Update tree operator from symbols to strings
This PR updates tree operators from symbols to strings.
Description
This is a follow up PR for https://github.com/microsoft/responsible-ai-toolbox/pull/1525 Use of "==" and "!=" confusing to non-programmers, update operators to strings
.
Feedback from a customer meeting: When the dashboard was using '!=' they didn't appreciate that this meant "Not Equal" - similarly "==" didn't mean anything to them. We should probably use more widely understood operators.
Acceptance criteria: Age == 41: Age equal to 41 Age != 41: Age not equal to 41 Age < 41: Age less than 41 Age > 41: Age greater than 41
Before:
After:
Checklist
- [x] I have added screenshots above for all UI changes.
- [ ] I have added e2e tests for all UI changes.
- [ ] Documentation was updated if it was needed.
Codecov Report
Merging #1528 (09aeacf) into main (9c66830) will decrease coverage by
6.89%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
- Coverage 87.27% 80.37% -6.90%
==========================================
Files 108 41 -67
Lines 5108 1687 -3421
==========================================
- Hits 4458 1356 -3102
+ Misses 650 331 -319
Flag | Coverage Δ | |
---|---|---|
unittests | 80.37% <ø> (-6.90%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c66830...09aeacf. Read the comment docs.
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/updateTreeOperator/dashboard/index.html
https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/updateTreeOperator/dashboard/index.html
Are there other places in the code where this needs to be changed? What about cohort conditions? example "age > 20"