regorus
regorus copied to clipboard
[Lib] Implement net builtins
- [ ] net.cidr_contains
- [ ] net.cidr_contains_matches
- [ ] net.cidr_expand
- [ ] net.cidr_intersects
- [ ] net.cidr_is_valid
- [ ] net.cidr_merge
- [ ] net.lookup_ip_addr
Ensure that cargo test -r --test opa -- netcidrcontains netcidrcontainsmatches netcidrexpand netcidrintersects netcidrisvalid netcidrmerge netcidroverlap netlookupipaddr passes.
Hey @anakrish - I'm a regular contributor to the OPA project and some of the others pointed me over here. I'm really excited to discover this library and I'd love to help you get some of these builtins implemented... I've been looking for a chance to get some OSS commits in rust as I seem to be spending most of my time in Go projects.
I'm going to take a crack at net.cidr_contains to start. I'm happy to work through all of these networking-related ones in time if you'd like to assign the issue to me. Since I'm newish to Rust, I'll probably open PRs for one builtin at a time so I can get good feedback about style and approach.
I'm on OPA slack with the same username. Would love to chat more about your project and how I can help
Hey @tjons, Welcome on board! It's really awesome to see a regular OPA contributor also take on features in Regorus!
If you are interested in Rust, #212 is also a great task to take on.
Hey @tjons, By any chance are you available on Teams?
@anakrish I'm not, sorry! Slack and my email is in my gh profile, happy to chat there. Still working on this as I've been busy, but having fun :)
Hey @anakrish and @tjons,
Good to see that you started working on the missing net functions!
I'd also be interested in this feature, and also willing to help with the implementation. Since you were looking for an off-Github comms channel, it's not quite clear to me what's going on. Would you mind posting an update on the current state?
Cheers, Markus
Hey @burgerdev - thanks for following along! It's been a little slow moving, as I've been learning the ropes of the project. net.cidr_is_valid merged this morning, and I'm working on net.cidr_contains today. I expect I'll have something up by the weekend...
Hey @burgerdev, @tjons is taking the lead for net builtins. Please feel free to coordinate and take on other builtins; currently all the communication is happening via github issues.
Thanks all, that's great! I'm mostly interested in net.cidr_contains - looking forward to it...