react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Support DebuggerBreakOnNextLine In Hermes

Open NickGerleman opened this issue 2 years ago • 4 comments

We have an instance setting, DebuggerBreakOnNextLine, which allows debugging the boot process. It is wired to Chakra and V8, but doesn't seem to effect Hermes. From feedback in teams, folks would find this functionality to be useful.

NickGerleman avatar Jan 10 '22 21:01 NickGerleman

@NickGerleman Is this supported by Hermes Windows itself and we need to hook it up in RNW? Or is it also lacking in Hermes Windows (in which case we need another issue on that repo as well).

chrisglein avatar Jan 13 '22 19:01 chrisglein

Timing here depends a lot on when the shift to Hermes as default happens. We also have gaps in postmortem debugging, for example. This one here seems pretty fundamental as well for good quality of life.

chrisglein avatar Jan 13 '22 19:01 chrisglein

@TatianaKapos Do you think this will make 0.69 or should it be moved to 0.70?

jonthysell avatar May 06 '22 23:05 jonthysell

@jonthysell Moved it to .70!

TatianaKapos avatar May 09 '22 17:05 TatianaKapos