react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Upgrade RNW toolchain to VS 2022 minimum (with v143 vclibs)

Open asklar opened this issue 2 years ago • 5 comments

Related to #8740 We should evaluate upgrading to the 143 vclibs since that's what is included by default in vs2022

It was a bit painful moving to 142 but obviously the right move; Office might be impacted by VC updates but the toolchain is going to continue to evolve.

asklar avatar Sep 29 '21 21:09 asklar

Previously when adopting 142 we had to support a switch while we were getting customers like Office migrated. Likely we'd need something like this so we can take on 143 earlier. Don't know how painful this will be to customers - need to do some legwork to figure out the right timing for this. Let's take on that as the next step.

Older versions of RNW will need to stay on VS2019 and vc142 though. So there will need to be some complexity for that regardless.

chrisglein avatar Sep 30 '21 18:09 chrisglein

Notes from planning poker:

Have tried upgrading the solution to VS2022. Using that with 142 seems to be fine, so 143 is probably fine? How does this affect key internal partners who are just barely on 142 - are they ready to move forward? (some won't be) If we have to straddle multiple versions like happened with 141 then that will have a large ongoing cost. If we don't do this, people who pick up VS latest (2022) will not get 142 by default. This will be a painful transition regardless.

chrisglein avatar Jan 22 '22 01:01 chrisglein

We build our solutions with whatever the "default" toolset is for the VS being used. So right now, if you open our solutions in VS 2022 and build, you're building with v143.

There may be edge cases with different platforms/configurations, and uwp/win32, but the bigger issue is switching our CI VMs to use VS 2022 (#9499) to get the coverage to verify everything can build in v143.

This is getting closer, leaving on 0.69 for now but this may move to 0.70.

jonthysell avatar May 06 '22 22:05 jonthysell

0.69 is getting too close for a sudden toolchain change, moving to 0.70.

jonthysell avatar Jun 09 '22 18:06 jonthysell

This is a priority for 0.71.

jonthysell avatar Aug 02 '22 23:08 jonthysell