react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Bundle and entry point js leverage the same value

Open namrog84 opened this issue 6 years ago • 1 comments

We write a cross platform app(Android, iOS, and Windows) that leverage the same entry point index.js at the moment. But the suggested path for windows bundling in DebugBundle and ReleaseBundle is to bundle into "index.windows.bundle"

But these names are sourced from the same point (loadBundle)

std::shared_ptr<IReactInstance> reactInstance;
...
// name of entry point (index.js)  but also name of bundle (index.bundle)
reactInstance->loadBundle(std::move("index"));

There should be some increased granularity and flexibility between defining an EntryPoint js and a bundle name.

Low pri. Can just generate index.bundle instead of index.windows.bundle and works fine for now.

namrog84 avatar Oct 29 '19 22:10 namrog84

Workaround exists (use the same names), but you should be able to customize this. What are the expectations from Android/iOS? Do they have naming assumptions? If they have customization options we should match that pattern.

chrisglein avatar Nov 06 '19 19:11 chrisglein