react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

[Fabric] Fix UIA_LiveSettingPropertyId to use VT_I4 datatype instead of VT_BSTR

Open ritoban23 opened this issue 1 month ago • 6 comments

Description

Fixes the UIA_LiveSettingPropertyId event to use the correct VT_I4 datatype instead of VT_BSTR for accessibility live region updates in Fabric. This ensures compliance with UIA requirements and improves accessibility event handling.

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

Why

The motivation for this change is to resolve an issue where the UIA_LiveSettingPropertyId event was being raised with the wrong datatype (VT_BSTR instead of VT_I4). This caused accessibility tools to misinterpret the live region setting, impacting screen reader behavior and overall accessibility compliance.

Resolves #15050

What

  • Updated CompositionViewComponentView.cpp to use the GetLiveSetting() conversion function for UIA_LiveSettingPropertyId.
  • The event now passes the correct integer value for live region settings ("polite", "assertive", "off") instead of a string.

Screenshots

N/A (no UI changes)

Testing

  • Verified that the correct datatype is now used for UIA_LiveSettingPropertyId events.
  • Ran linting and formatting as required by the repository.
  • No new tests were added, but the change was validated by manual inspection and build checks.

Optional: Ran local builds and checked accessibility event output for correctness.

Changelog

Should this change be included in the release notes: yes

Release Notes Summary:
Fixes accessibility event datatype for UIA_LiveSettingPropertyId in Fabric, ensuring proper screen reader support and UIA compliance.

Microsoft Reviewers: Open in CodeFlow

ritoban23 avatar Dec 03 '25 02:12 ritoban23

@microsoft-github-policy-service agree

ritoban23 avatar Dec 03 '25 02:12 ritoban23

/azp run PR

vineethkuttan avatar Dec 03 '25 04:12 vineethkuttan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 03 '25 04:12 azure-pipelines[bot]

This is a manually created file, this won't work. Delete this

Run yarn change in your local repo, follow this doc

Looks like the format is ok. Its likely ok as is. It does look like you are missing parts of your changes though.

acoates-ms avatar Dec 04 '25 17:12 acoates-ms

/azp run PR

vineethkuttan avatar Dec 12 '25 05:12 vineethkuttan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 12 '25 05:12 azure-pipelines[bot]