Modern Inspector Outstanding Issues

[vmoroz]

Modern Inspector Outstanding Issues

Follow-ups from PR #15328 (Add support for modern inspector)

• [ ] Implement the NetworkIOAgent pathway so the modern inspector can fetch network resources on Windows (ReactInspectorHostTargetDelegate::loadNetworkResource in vnext/Microsoft.ReactNative/ReactHost/ReactHost.cpp). Source: PR description and docs/modern-inspector-details.md.(This will taken up in 0.82 #15369 )
• [x] Enrich the host target metadata that we expose to the inspector (reuse the app identity and current debugger naming instead of the placeholder string). Tracked in review thread https://github.com/microsoft/react-native-windows/pull/15328#discussion_r2500968672 and issue https://github.com/microsoft/react-native-windows/issues/15342. (Done in PR #15375)
• [x] Replace the temporary inspector page name ("React Native Windows (Experimental)") with the final identity we want to surface in DevTools. Tracked in review thread https://github.com/microsoft/react-native-windows/pull/15328#discussion_r2500972876 and issue https://github.com/microsoft/react-native-windows/issues/15342. (Done in PR #15375)
• [x] Decide whether DevSupportManager::OpenDevTools should remain and, if so, wire it up to the active dev server configuration instead of the baked-in localhost:8081 default (vnext/Shared/DevSupportManager.cpp). (Removed in PR #15392)
• [x] Extract the variadic string_format helper out of DevServerHelper (or replace it) so we stop hand-rolling snprintf plumbing (vnext/Shared/DevServerHelper.h). (Done in PR #15392 - we must avoid copy by using std::stirng directly instead of unique_ptr)
• [x] ~~Track modern inspector parity for Chakra-based runtimes (Chakra still falls back to legacy debugging). Source: docs/modern-inspector-details.md.~~ We removed Chakra support from main.
• [x] Provide the real process ID to the RuntimeSamplingProfile constructor in HermesRuntimeTargetDelegate.cpp (Done in PR #15392)
• [x] Remove support for the old sampling profiler and all the related Hermes wiring for it. The old profiler was added in PR #11033. We must see if any of that code is still around and if yes, then we should delete it.(Done in PR #15392)
• [ ] See if the debugger paused overlay and the debugger component overlay work correctly with font size 150%.

Follow-ups noted in prototype PR #13008 (Wire up Fusebox in react-native-windows)

• [x] Defer inspector setup in ReactNativeHost until the first instance reload so feature flags can be toggled after host construction (comment: https://github.com/microsoft/react-native-windows/pull/13008#discussion_r1586916335). (It was done in the original PR #15328)
• [ ] Fix the debugger paused flyout dismissing itself when the app window is resized (comment: https://github.com/microsoft/react-native-windows/pull/13008#discussion_r1586918652). (@vmoroz: This comment was done against paper we should check if Fabric is OK)
• [ ] Relocate the Ctrl+Shift+I dev tools shortcut wiring to a non-hacky location that can see both DevSettings and all active XamlRoots (comment: https://github.com/microsoft/react-native-windows/pull/13008#discussion_r1586919175).
• [x] Revisit the dedicated inspector serial queue to confirm we tear everything down safely; we may need additional lifetime management (comment: https://github.com/microsoft/react-native-windows/pull/13008#discussion_r1586919810). (@vmoroz: it seems to be OK for now)