react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

[Fabric] Raised UIA Update event with wrong datatype.

Open vineethkuttan opened this issue 5 months ago • 4 comments

https://github.com/microsoft/react-native-windows/blob/b26e704a74b8ea037ba50917cf53c6c869c6077c/vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.cpp#L801-L805

For UIA_LiveSettingPropertyId we are supposed to raise event using the VT_I4 datatype but we raised event with argument VT_BSTR Ref.

Change Required:

winrt::Microsoft::ReactNative::implementation::UpdateUiaProperty(
      EnsureUiaProvider(),
      UIA_LiveSettingPropertyId,
      GetLiveSetting(oldViewProps.accessibilityLiveRegion),
      GetLiveSetting(newViewProps.accessibilityLiveRegion));

Where this change trigger the event with appropriate arguements.

vineethkuttan avatar Aug 12 '25 04:08 vineethkuttan

hey , i would like to submit a PR if its open to contribution

ritoban23 avatar Aug 13 '25 14:08 ritoban23

hey , i would like to submit a PR if its open to contribution

Hey @ritoban23 , Thanks for your interest! This issue is already assigned, but feel free to look for another good first issue to contribute to.

vineethkuttan avatar Aug 14 '25 06:08 vineethkuttan

Hi @ritoban23 , would you like to submit a PR now.

vineethkuttan avatar Nov 30 '25 12:11 vineethkuttan

@vineethkuttan sure, will make a PR soon!

ritoban23 avatar Nov 30 '25 13:11 ritoban23