react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Implement JSRuntime enableSamplingProfiler, disableSamplingProfiler, and collectSamplingProfile

Open TatianaKapos opened this issue 7 months ago • 0 comments

Problem Description

Upstream added the following methods to their RuntimeAgent (see linked commits) and our HermesRuntimeHolder would need to implement these methods.

  • enableSamplingProfiler
  • disableSamplingProfiler
  • collectSamplingProfile

Currently stubbed these methods out but unsure if we need a proper implementation

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/14693

Link to commit

https://github.com/facebook/react-native/pull/48836/files https://github.com/facebook/react-native/pull/48315/files

Forked files

Stub Methods in

  • vnext/Shared/HermesRuntimeHolder.cpp
  • vnext/Shared/HermesRuntimeHolder.h
  • TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.cpp
  • ReactCommon/TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.h

Upstream PR

N/A - we will need to implement in our code

Build Configuration

None

TatianaKapos avatar May 24 '25 00:05 TatianaKapos