react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Unfork ReactPerfettoLogger.cpp

Open TatianaKapos opened this issue 7 months ago • 0 comments

Problem Description

Upstream added methods to ReactPerfettoLogger.cpp that use their internal fbsystrace API as fallback, since we don't take in that API, Visual Studio throws errors because they don't know where to find the methods added.

Currently commented out these methods. I don't think our code relies on the fallback so this may be enough for now.

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/14693

Link to commit

https://github.com/facebook/react-native/pull/49657

Forked files

  1. TEMP_UntilReactCommonUpdate/reactperflogger/reactperflogger/ReactPerfettoLogger.cpp

Upstream PR

N/A

Build Configuration

None

TatianaKapos avatar May 23 '25 23:05 TatianaKapos