react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Remove view/conversions.h overrides

Open TatianaKapos opened this issue 7 months ago • 0 comments

Problem Description

Upstream recently edited ‎packages/react-native/ReactCommon/react/renderer/components/view/conversions.h which incorrectly casts an double to a float. Added a one-line fix to static_cast to a float

Added code: return static_cast<float>(std::get<CSSAngle>(angle).degrees * M_PI / 180.0f); // [Windows]

This should be an easy PR to make upstream.

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/14693

Link to commit

https://github.com/facebook/react-native/commit/c99b71780bae6e93ad54e0a00daa31729e3bd547

Forked files

1.vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/conversions.h

Upstream PR

N/A

Build Configuration

None

TatianaKapos avatar May 23 '25 23:05 TatianaKapos