react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Implement overflow property for Image for fabric

Open jonthysell opened this issue 1 year ago • 3 comments

Implement the overflow property for the fabric implementation of Image.

Note: This property appears in both Layout Props and Image Style Props.

This property was available in RNW Paper via NativeUIManager.

See https://reactnative.dev/docs/image-style-props#overflow for details.

jonthysell avatar Apr 30 '24 16:04 jonthysell

In the Paper implementation, if the property was set in the component, the overflow value would be set to the corresponding YGOverflow type defined here: https://github.com/facebook/react-native/blob/1b24182a172b061993b7c78833aaa41cddc85679/packages/react-native/ReactCommon/yoga/yoga/enums/Overflow.h#L19.

In Paper, the property is processed in the following file: vnext\Microsoft.ReactNative\Modules\NativeUIManager.cpp. ~~Looking at the Fabric code, the best place to start would likely be vnext\Microsoft.ReactNative\Fabric\Composition\ImageComponentView.cpp~~

Edit: following on from Tatiana's comment below, best place to start would be vnext\Microsoft.ReactNative\Fabric\Composition\CompositionViewComponentView.cpp

Yajur-Grover avatar Apr 02 '25 17:04 Yajur-Grover

This is a Layout Property that needs to be applied to all component, most likely this will be implemented in CompositionViewComponentView and then inherited from the rest of the components

TatianaKapos avatar Apr 03 '25 00:04 TatianaKapos

@jonthysell @HariniMalothu17 hi i'd like to contribute to this issue

rishabhjain1712 avatar Oct 12 '25 15:10 rishabhjain1712