react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Rename IReactPackageProvider for Playground-win32

Open rozele opened this issue 1 year ago • 1 comments

Description

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

Why

We build react-native-windows Playground-win32 with buck, which errors when two headers have the exact same name without being nested in namespace sub-folder.

What

This ensures the header name (ReactPackageProvider.g.h) does not conflict with header names from @react-native-picker/picker.

Testing

Playground-win32 still compiles, and the nativeLayout example works again.

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

rozele avatar Dec 13 '23 01:12 rozele

Reviewed in triage. Change seems reasonable. Will merge once CI runs green.

chiaramooney avatar Jan 30 '24 23:01 chiaramooney