react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Integrate 7/14 RN Nightly Build

Open chiaramooney opened this issue 2 years ago • 1 comments

Description

Type of Change

  • Integration

Why

Integrate 7/14 Nightly Build https://github.com/facebook/react-native/compare/68f3a42fc...8af7870c6

What

  • Add offsetX and offsetY to mouse event https://github.com/facebook/react-native/commit/d9b8e07b0065db8371e849dcc5137aeb36a97e5a
  • Metro dependencies to 0.71.3 https://github.com/facebook/react-native/commit/bdeb4e065532dfb1bb4c9c1e87e8a869a737e48a
  • RNCLI 9.0.0-alpha.3 https://github.com/facebook/react-native/commit/2b49ac6f8b04953be4cd5bf0b1325986b117763c

chiaramooney avatar Aug 03 '22 21:08 chiaramooney

Updating the various CLI packages here closes #8755

jonthysell avatar Aug 09 '22 20:08 jonthysell

I've verified locally that when using hermes-windows 0.12.1 with this integrate (as it stands) causes apps to crash on start (what we're seeing in the PR checks).

I've also verified locally that using a version of hermes-windows with the updates @vmoroz made in this PR https://github.com/microsoft/hermes-windows/pull/118 fixes the app crash.

So as soon as a new version of hermes-windows has been published, we should be able to start consuming it in this PR, and get further unblocked.

jonthysell avatar Aug 17 '22 18:08 jonthysell

Woohoo! Now all we need is to do the enum remapping so we don't break binary compatibility

jonthysell avatar Aug 18 '22 18:08 jonthysell

I have extracted and moved the kind enum remapping logic to it's own file - we need to sit down and hash out whether or not it's worth all the work to deviate (and whether that needs to keep blocking this very delayed integration).

jonthysell avatar Aug 18 '22 23:08 jonthysell