react-native-windows Fix relative include path for Views/Image

Fix relative include path for Views/Image

Open rozele opened this issue 1 year ago • 2 comments

Description

Type of Change

Erase all that don't apply.

Bug fix (non-breaking change which fixes an issue)

Why

The DynamicAutomationPeer.h header is in the parent Views folder and this include path is not supported by clang.

What

This change adjusts the include path.

Microsoft Reviewers: Open in CodeFlow

Jul 19 '22 15:07 rozele

I think including "../foo.h" goes against some cpp core guideline... trying to find the link...

Jul 21 '22 18:07 asklar

@asklar - fixed

Jul 23 '22 18:07 rozele

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Aug 15 '22 16:08 ghost

react-native-windows react-native-windows copied to clipboard

Fix relative include path for Views/Image

Description

Type of Change

Why

What

Microsoft Reviewers: Open in CodeFlow

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

react-native-windows
react-native-windows copied to clipboard

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.