react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Component Governance: Update to `[email protected]` to remove dependency on `string_decoder`

Open jonthysell opened this issue 2 years ago • 2 comments

This PR adds a resolution to use the latest readable-stream package, which no longer depends on the legacy string_decoder package which causes CG alerts.

One side-effect of this is that this expects Node 12 or greater, though since we already require Node 14 or greater, this shouldn't be a problem per-se, but may limit how far back we can backport this change.

Microsoft Reviewers: Open in CodeFlow

jonthysell avatar Jul 11 '22 20:07 jonthysell

Hello @jonthysell!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours 47 minutes. No worries though, I will be back when the time is right! :wink:

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost avatar Jul 11 '22 20:07 ghost

It looks like the package lazystream (ultimately used by @react-native-windows#automation#webdriverio#archiver#archiver-utils#lazystream) cannot consume the newer readable-stream due to how it imports the PassThrough type.

jonthysell avatar Jul 11 '22 20:07 jonthysell