Breaking changes for 2.0

[tido64]

Description

A collection of breaking changes.

Note: This PR must not be squashed before merging.

Resolves #715.

Platforms affected

• [ ] Android
• [ ] iOS
• [ ] macOS
• [ ] Windows

Test plan

npm run set-react-version 0.64
yarn
cd example
rm ios/Podfile.lock macos/Podfile.lock

# Test Android
yarn android

# Test iOS
pod install --project-directory=ios
yarn ios

# Test macOS
pod install --project-directory=macos
yarn macos

# Test Windows
yarn install-windows-test-app
yarn windows

[Saadnajmi]

Can't find the original issue, but something something remove duplicate xcscheme was one for 2.0 as well?

[tido64]

Can't find the original issue, but something something remove duplicate xcscheme was one for 2.0 as well?

#715 lists it. I wanted to keep it since it helps with scripting. Faster to use ReactTestApp as scheme than running xcodebuild -list and parsing the output. Happy to be convinced otherwise. Is this breaking anything on your side?

[Saadnajmi]

Nah, I was thinking similarly. I didn't have a strong want to remove it besides redundancy.If we still wanted to remove redundancy and instead removed the scheme whose name matched the test app name, that would be a relatively easy breaking change to handle for us anyway. But I don't have a strong opinion either way.

[kelset]

update: fixed my iOS problem, managed to test iOS just fine ✅

last bit missing is testing on Windows but I can't help with that

[tido64]

I ran a last check on Windows to be sure: