react-native-code-push
react-native-code-push copied to clipboard
Codepush HOC should unmount app before restart
RN Apps currently don't get the opportunity to destruct themselves prior to a restart, leading to crashes and bugs:
https://github.com/microsoft/react-native-code-push/issues/2567#issuecomment-1820827232
This is an attempt to mitigate these crashes, by properly unmounting <App />
.
I'm looking forward to your feedback
@microsoft-github-policy-service agree
ping?
this is not missing the state in the class construtor?
constructor() {
super();
this.state = { inactive: false };
}
@savv Thank you for this contribution! I'm a bit concerned that we may affect existing apps with this change. I think it would be a good idea to put this change behind an option (for now), what do you think?
Closing as stale.