react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Fix Android rollbacks when app started on background

Open aamagda opened this issue 2 years ago • 3 comments

Fixes for this issue https://github.com/microsoft/react-native-code-push/issues/2305

aamagda avatar Aug 10 '22 14:08 aamagda

CLA assistant check
All CLA requirements met.

ghost avatar Aug 10 '22 14:08 ghost

@chrisglein @jedashford @andreidubov @alexandergoncharov-zz Hi, guys! Could you help with tagging repo maintainers?

aamagda avatar Aug 30 '22 14:08 aamagda

@chrisglein @jedashford @andreidubov @alexandergoncharov-zz could you review and merge this PR?

ddikodroid avatar Sep 13 '22 05:09 ddikodroid

up

aamagda avatar Mar 08 '23 21:03 aamagda

@thewulf7 @appcenter-fte 👋 Could you review this PR, please. It's still actual.

aamagda avatar May 30 '23 12:05 aamagda

Hello @aamagda , we looked at your pull request, I have concerns that in this case the case will not be processed when a rollback needs to be performed due to ~~an unsuccessful update download or~~ invalid jsbundle. Which actually checks by calling notifyAppReady when the application is rendered. What will happen in this case? I think this case needs to be handled too.

MikhailSuendukov avatar May 31 '23 12:05 MikhailSuendukov

@aamagda Any updates regarding this PR? I'm facing the same issue

shehabeldeenibrahim avatar Oct 15 '23 14:10 shehabeldeenibrahim

Closing due to contributor not responding. Feel free to re-open when responding.

velimir-jankovic avatar Nov 08 '23 13:11 velimir-jankovic