qlib icon indicating copy to clipboard operation
qlib copied to clipboard

Deprecated class Text of module typing

Open RequieMa opened this issue 1 year ago • 6 comments

🐛 Bug Description

image

Is this type of pylint suggestion required to consider from your perspective?

RequieMa avatar Jun 24 '24 12:06 RequieMa

Hi, I pulled the latest code, ran the pylint command, and did not find the problem you describe. I found the error code R0201 in your command, which is not present in the latest code.

The command I used was:

  • The hit for testing the complete qlib folder: https://github.com/microsoft/qlib/blob/main/.github/workflows/test_qlib_from_source.yml#L109
  • For the gbdt.py file: pylint --disable=C0104,C0114,C0115,C0116,C0301,C0302,C0411,C0413,C1802,R0401,R0801,R0902,R0903,R0911,R0912,R0913,R0914,R0915,R1720,W0105,W0123,W0201,W0511,W0613,W1113,W1514,E0401,E1121,C0103,C0209,R0402,R1705,R1710,R1725,R1735,W0102,W0212,W0221,W0223,W0231,W0237,W0612,W0621,W0622,W0703,W1309,E1102,E1136 --const-rgx='[a-z_][a-z0-9_]{2,30}$' qlib/contrib/model/gbdt.py --init-hook "import astroid; astroid.context.Inferenc eContext.max_inferred = 500; import sys; sys.setrecursionlimit(2000)"

SunsetWolf avatar Jun 25 '24 05:06 SunsetWolf

Quite weird. I'm using the latest version image I tried with your command. It gave a different error code W4904, but the same reason 'deprecated-class'

RequieMa avatar Jun 25 '24 12:06 RequieMa

typing.Text can be replaced by str and was deprecated since python 3.11 according to gh-92332.

qew21 avatar Jun 26 '24 03:06 qew21

Quite weird. I'm using the latest version image I tried with your command. It gave a different error code W4904, but the same reason 'deprecated-class'

I tested gbdt.py after upgrading pylint to 3.2.4 and found no problems.

SunsetWolf avatar Jun 27 '24 05:06 SunsetWolf

W4904 python 3.11.5 pylint 3.2.4

qew21 avatar Jun 27 '24 07:06 qew21

I don't think it makes sense to test with python 3.11, since qlib currently supports the following python versions: 3.7 and 3.8.

SunsetWolf avatar Aug 22 '24 06:08 SunsetWolf