qlib icon indicating copy to clipboard operation
qlib copied to clipboard

fix the bug that the HS_SYMBOLS_URL is 404

Open zhstark opened this issue 1 year ago • 2 comments

Description

Discard using HS_SYMBOLS_URL in scripts/data_collector/utils.py get_hs_stock_symbols(), since the url is no longer available. Use api of eastmoney.com/api, the same api that used in method get_us_stock_symbols(), to get hs stock symbols.

Motivation and Context

it can solve the issue #1757

How Has This Been Tested?

  • [x] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • [ ] If you are adding a new feature, test on your own test scripts.

Types of changes

  • [x] Fix bugs
  • [ ] Add new feature
  • [ ] Update documentation

zhstark avatar Mar 12 '24 12:03 zhstark

@microsoft-github-policy-service agree

zhstark avatar Mar 12 '24 12:03 zhstark

Thank you for submitting pull requests, after testing found that the current code can't fetch the data successfully, the code in the collection of _get_symbol method should yahoo's specification, but currently it doesn't. Also please fix CI.

SunsetWolf avatar May 15 '24 07:05 SunsetWolf