qdk icon indicating copy to clipboard operation
qdk copied to clipboard

[Samples] Investigate redundant Check

Open Manvi-Agrawal opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. There exists a typescript test that executes samples in samples.mjs (Code link ) . IMO, it would be good to investigate whether it is relevant in the current scenario after this repo has been enhanced for testing efficiency primarily in #1533 #1797. As per my understanding we are now checking for lint and sample execution for all samples, so it might be a good idea to get rid of redundancy.

Describe the solution you'd like A clear and concise description of what you want to happen. Get rid of redundant test if its no longer required.

Describe alternatives you've considered Dont remove the test if its needed.

Additional context

  • Earlier, observation raised in https://github.com/microsoft/qsharp/issues/1709 based on Q# infra at the time of raising the issue.
  • See this comment

Manvi-Agrawal avatar Sep 25 '24 16:09 Manvi-Agrawal

@Manvi-Agrawal Yep, this seems like a redundancy and removing that JS would be practical.

sezna avatar Oct 14 '24 20:10 sezna

Hi @Manvi-Agrawal @sezna , Can I work on this issue?

prkbuilds avatar Nov 14 '24 16:11 prkbuilds

@PratikFandade sounds good. This should be fairly straightforward. Let me know if need any help with this.

Manvi-Agrawal avatar Nov 14 '24 18:11 Manvi-Agrawal