python-language-server icon indicating copy to clipboard operation
python-language-server copied to clipboard

Improve linting of LHS expressions

Open MikhailArkhipov opened this issue 5 years ago • 1 comments

Fixes #2068

Original condition was too harsh. Intent was to avoid reporting of variables that are actually being defined, but that can be done by skipping over name expressions in LHS.

MikhailArkhipov avatar Jun 09 '20 15:06 MikhailArkhipov

Seems to fail the NoRightSideCheck test.

My test was something like:

y = {}
invalid.access, another.access, (y.okay, fake.variable.access) = [1, 2, (3, 4)]

But the current code appears to correctly only squiggle invalid, another, and fake.

jakebailey avatar Jun 16 '20 23:06 jakebailey