microsoft
`diagnosticMode` is no longer defaulting to "openFilesOnly"
With the latest changes in "main", I noticed that the diagnosticMode setting is no longer defaulting to "openFilesOnly". The Pyright VS Code extension is now analyzing all of the files in my projects.
@rchiodo, looks like this is fallout from your settings change. Do you have time to look into this today, or should I?
@rchiodo, it looks like this affects more than just diagnosticMode. A bunch of functionality is broken in the VS Code extension for pyright. It's pretty much unusable currently. I'm going to revert your change for now.
I'm not reproducing. Do you have an example layout? I only see errors for the opened files.
Maybe it's a background analysis thing. As the config settings are somehow getting lost when passed to the background thread. I'm running debug bits.
Reproing now. Not sure what the problem was.
It seems there are some settings that should always be applied. 'checkOpenFilesOnly' is one of them. I'll need to double check all of the options in 'CommandLineOptions' to make sure they're not one of the json allowed settings.
Maybe it would be good to separate the parts of the CommandLineOptions into two sections. 'Json/pyproject.toml' configurable parts and those that are command line only.
Yeah, sounds reasonable. Maybe move all of the Json/pyproject.toml configurable fields into a sub-structure that hangs off CommandLineOptions?