pyright icon indicating copy to clipboard operation
pyright copied to clipboard

workspaceEdit missing changeAnnotations

Open latifboubyan opened this issue 5 months ago • 3 comments

Hello,

I'm facing an issue where the rename capability is broken because the issue reported here: https://github.com/neovim/neovim/issues/34731

It seems problem has to do with the fact that when rename generates a workspaceEdit, it returns AnnotatedTextEdits but without a changeAnnotations field. So a client trying to use the annotation IDs will break.

This is a good description of the issue.

latifboubyan avatar Jul 02 '25 19:07 latifboubyan

This was fixed in basedpyright https://github.com/DetachHead/basedpyright/pull/1352

latifboubyan avatar Jul 02 '25 19:07 latifboubyan

I'd accept a PR to fix this issue if you're interested in making a contribution.

erictraut avatar Aug 31 '25 10:08 erictraut

I have been running the suggested change committed in basedpyright for a few weeks now. I am in the process of testing/linting and will open a PR presently.

stvsmth avatar Sep 06 '25 15:09 stvsmth