pylance-release icon indicating copy to clipboard operation
pylance-release copied to clipboard

Find all references doesn't look in closed notebook files

Open rchiodo opened this issue 2 years ago • 3 comments

Repro steps:

  1. Git clone https://github.com/bokeh/tutorial
  2. Open a bunch of the notebooks. They all have this code at the top:
# activate notebook output
from bokeh.io import output_notebook

output_notebook()
  1. Find all references on output_notebook

Expected result: At least finding references in all of the open notebooks

Actual result: Finds the reference only in the current notebook

rchiodo avatar Nov 29 '23 22:11 rchiodo

need to check if this is a regression

judej avatar Nov 30 '23 19:11 judej

This is not a regression and is really because we can't search on disk.

The root cause of the problem is that notebook tabs are open in VS code but they weren't clicked on to cause the notebook to render. The notebookDocument/open even was never sent.

So the root of the problem is that we can't search on disk.

rchiodo avatar Nov 30 '23 21:11 rchiodo

See this issue for how we could solve this problem: https://github.com/microsoft/vscode/issues/177391

rchiodo avatar Aug 26 '24 16:08 rchiodo