pylance-release icon indicating copy to clipboard operation
pylance-release copied to clipboard

pyright command except generate stub is not connected to pylance

Open heejaechang opened this issue 2 years ago • 2 comments

it looks like at some point, we stopped calling pyright's command controller.

so pyright's code action such as add missing optional params or order imports no longer work.

basically, no one is handling these PyrightCommand anymore. https://github.com/microsoft/pyrx/blob/main/packages/pylance-internal/src/commands/commandController.ts#L100

pylance should call pyright's command controller if commands are not one that pylance handle.

heejaechang avatar Nov 29 '23 03:11 heejaechang

related issue - https://github.com/microsoft/pyright/issues/6571

heejaechang avatar Nov 29 '23 04:11 heejaechang

This is probably my fault, sync/async server redesign.

rchiodo avatar Dec 05 '23 21:12 rchiodo

Is this still a problem? I think this is fixed now?

rchiodo avatar Oct 04 '24 21:10 rchiodo