pxt icon indicating copy to clipboard operation
pxt copied to clipboard

chain skillmap npm install

Open pelikhan opened this issue 2 years ago • 4 comments

The requirement to run npm install in /skillmaps is undocumented and very annoying. This should make it automatic.

pelikhan avatar Sep 15 '22 20:09 pelikhan

@pelikhan is gulp not doing this for you? are you on an old branch maybe?

I added this to the gulpfile recently:

https://github.com/microsoft/pxt/commit/b2b87663e6514fecbcfad49cf435e3b43a4aec95

riknoll avatar Sep 15 '22 20:09 riknoll

I guess I had an old distro, and running "./pxt> npm install" did not trigger running "./pxt/skillmaps> npm install" as well

pelikhan avatar Sep 15 '22 20:09 pelikhan

@pelikhan is gulp not doing this for you? are you on an old branch maybe?

I added this to the gulpfile recently:

b2b8766

After the React 17 update, I did actually have to manually run npm install inside the skillmap folder for "gulp watch" to work. Haven't looked into why yet (it's on my to do list), but thought I should mention it. Seems like this change could be helpful, though.

thsparks avatar Sep 16 '22 17:09 thsparks

I did 'npm install'. what gulp command should i run?

pelikhan avatar Sep 16 '22 17:09 pelikhan

This has been fixed. Close?

eanders-ms avatar Oct 26 '22 18:10 eanders-ms