pxt icon indicating copy to clipboard operation
pxt copied to clipboard

Missing images on some docs pages

Open Jaqster opened this issue 3 years ago • 10 comments

Noticed that some images were missing from these docs pages: https://arcade.makecode.com/identity/cloud-sync image

https://arcade.makecode.com/identity/sign-in image

Jaqster avatar Jan 29 '22 20:01 Jaqster

Hmm, this happens with the github pages too:

https://arcade.makecode.com/github/sign-up

The images in common_docs pages aren't being pulled from their ./common-docs/static location but from the current ./target/docs/static location?

ganicke avatar Jan 31 '22 04:01 ganicke

@shakao - any ideas why these images aren't found?

image

Works with local serve:

image

ganicke avatar Jan 31 '22 19:01 ganicke

yeah weird, it looks like we're not looking for images under /common-doc, but it doesn't seem like any of that code has changed recently.... @aznhassan any idea if anything in our backend path expansion might have affected this?

shakao avatar Jan 31 '22 22:01 shakao

Ummm.... these pages are down now. What's going on? image

image

Jaqster avatar Feb 16 '22 18:02 Jaqster

@Jaqster I can reach those pages. Internet issues?

abchatra avatar Feb 16 '22 18:02 abchatra

I think you're missing the arcade. subdomain~

jwunderl avatar Feb 16 '22 18:02 jwunderl

Hmmmm... no internet issues. Tried lots of other docs pages and different browsers. These are the right links (not on Arcade domain) - they are linked from Eric's blog post - https://makecode.com/blog/arcade/intro-cloud-sync

Jaqster avatar Feb 16 '22 18:02 Jaqster

Those links in the blog are incorrect as these pages are inherited by targets from pxt ./common-docs.

ganicke avatar Feb 16 '22 18:02 ganicke

Okay, can we change those links in the blog post then?

Jaqster avatar Feb 16 '22 18:02 Jaqster

But, of course... #8715

ganicke avatar Feb 16 '22 19:02 ganicke