pxt icon indicating copy to clipboard operation
pxt copied to clipboard

fix tab navigation in side docs

Open riknoll opened this issue 6 months ago • 1 comments

fixes https://github.com/microsoft/pxt-microbit/issues/6330

this pr fixes a few side docs tab navigation bugs

  • the "go back" button wasn't tab navigable. it now has a tabindex and was converted to an <a> element
  • the pop-out button was at the end of the tab order in the side docs. it's now the first element in the order
  • the rendered SVG blocks still had the tabindex attribute on some elements

riknoll avatar Jun 20 '25 00:06 riknoll

What pop-out button are you referring to? Is it this one? image It's first in the tab order for me in beta and live when I open the help docs. Or did adding the a tag mess with things?

srietkerk avatar Jun 20 '25 18:06 srietkerk

@srietkerk no, the one that appears in the top-right of the side docs and opens the page in a new tab

riknoll avatar Jun 24 '25 16:06 riknoll