pxt icon indicating copy to clipboard operation
pxt copied to clipboard

use anchor element for social links when in game

Open riknoll opened this issue 1 year ago • 3 comments

fixes https://github.com/microsoft/pxt-minecraft/issues/2668

the in-game webview on macos doesn't support any of the window open APIs that the browser provides.<a> elements work though, so this PR replaces the social buttons with <a> elements.

normally i would just replace these for all platforms since <a> elements are usually better for accessibility, but the only way to open a pop up window is with js and i think that's the expected behavior for social buttons. doesn't matter for the in-game experience given that those all open in the browser outside the game anyhow.

riknoll avatar Nov 19 '24 22:11 riknoll

@riknoll build failing

abchatra avatar Nov 19 '24 22:11 abchatra

@abchatra i'll fix it, but leave this one out of the release anyhow. i'd like more people to test it first so let's save it for the hotfix

riknoll avatar Nov 19 '24 23:11 riknoll

Sounds good.

abchatra avatar Nov 19 '24 23:11 abchatra