pxt-microbit icon indicating copy to clipboard operation
pxt-microbit copied to clipboard

Teacher Tools: Evaluate results is incorrect when evaluate criteria has negative number parameters

Open v-katherine opened this issue 1 year ago • 1 comments

Describe the bug Teacher Tools: Evaluate results is incorrect when evaluate criteria has negative number parameters

Steps to reproduce the behavior 1.Navigate to MakeCode Teacher Tool (microbit.org). 2.Open a checklist, enter Project Link or Share ID and submit. 3.Open a checklist and change the number in numeric parameter as negative number. 4.Click Evaluate button and observe the results.

Actual behavior: The result shows 'Look Good' even though the number is negative number.

Expected behavior: Cannot evaluate the numeric parameters criteria.

Screen Recording: resultswrong

Additional context: 1.OS: Windows11, iMac Ventura 13.6.6 2.makecode.microbit,org version: 7.0.9 3.Microsoft MakeCode version: 10.0.21

v-katherine avatar May 09 '24 05:05 v-katherine

This bug also reproduced when input 0 in the numeric parameters

v-katherine avatar May 09 '24 05:05 v-katherine

I verified this bug in the latest version: 7.0.40 and it has been fixed.

Ramanan0530 avatar Sep 13 '24 06:09 Ramanan0530