pxt-microbit icon indicating copy to clipboard operation
pxt-microbit copied to clipboard

Comment sizes wrong in shared project view

Open martinwork opened this issue 2 years ago • 4 comments

Describe the bug When loading a shared project, comment sizes are wrong until you click Edit to open the editor.

Example: https://makecode.microbit.org/_iUwfRz5hzWXz

To Reproduce Steps to reproduce the behavior:

  1. Create a project with resized comments
  2. Share the project
  3. Visit the shared project URL
  4. See error

Expected behavior The comment sizes are right.

Screenshots Original project: image

Shared project view: image

micro:bit version (please complete the following information): not hardware related

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows 10
  • Browser [e.g. chrome, safari] Chrome, Edge, Firefox
  • Version [e.g. 22] 108

martinwork avatar Jan 12 '23 16:01 martinwork

Is this related to comments moving location? e.g. between the editor view when shared: image

and the project as opened from shared link: image (comments now obscure blocks, overlapping persists when opened it editor)

microbit-giles avatar Mar 02 '23 11:03 microbit-giles

@microbit-giles The comments in my example aren't attached to a block. They are right once loaded into the editor - just wrong in the shared project view.

I didn't realise the attached comments positioning was a change from MakeCode v4.

With this example, created in MakeCode v4, using Import URL, v4 puts the comment in it's custom position, but v5 moves it to the default position. It's the same for shared projects and loading a hex file. https://makecode.microbit.org/_KJaVoReM8Rp0

martinwork avatar Mar 02 '23 11:03 martinwork

Still repros in new Blockly

Jaqster avatar Aug 23 '24 17:08 Jaqster

Trying the original project (https://makecode.microbit.org/_iUwfRz5hzWXz) today, the shared project Blocks view is blank, and the JavaScript view shows just one comment, initially as /**... image

The comment are minimised in the editor - maybe that's not new? image

When expanded, they seem OK: image

When imported into beta, they arrive expanded, but with a different font, and it looks like there is a minimum width. image

martinwork avatar Aug 30 '24 20:08 martinwork

The beta behaviour referred to above has been live for a while and seems OK to me.

microbit-matt-hillsdon avatar Mar 26 '25 17:03 microbit-matt-hillsdon

This is fixed.

abchatra avatar Jun 25 '25 18:06 abchatra