pxt-microbit icon indicating copy to clipboard operation
pxt-microbit copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Issue with embedded MakeCode environments in OneNote

Open kiki-lee opened this issue 2 years ago • 3 comments

From a Twitter user:

there's this issue with embedded makecode environments at a certain resolution where the emulator doesn't load. any chance theres a fix comming soon? Thanks

image

When asked to try the same thing on the desktop version:

same result.

image

kiki-lee avatar Aug 17 '22 21:08 kiki-lee

I can repro this. And it's across editors... image

Jaqster avatar Aug 18 '22 19:08 Jaqster

This is likely because we dropped support for IE11. If I remember correctly this was dependent on IE11 rendering engine. Do we have contact in the team? We should check if there is a way to invoke modern engine .

abchatra avatar Aug 31 '22 23:08 abchatra

I got the contact. Lets first investigate and ensure that is the issue.

abchatra avatar Aug 31 '22 23:08 abchatra

I don't think this is because of IE. When I inspect the element in OneNote and view console output, we can see it says it's using Chrome (which probably means it's actually edge): image

thsparks avatar Jun 20 '23 21:06 thsparks

This bug repros even on just a regular share page. I think the reason we noticed it in OneNote is because it only happens on small sizes, and the default OneNote embed section is pretty tiny.

Still investigating root cause...

thsparks avatar Jun 20 '23 23:06 thsparks

Awesome find

abchatra avatar Jun 20 '23 23:06 abchatra

This is partially addressed by https://github.com/microsoft/pxt/pull/9570 and should at least be usable once that gets released. That said, there may be future improvements worth considering here, like:

  1. Fixing the gap on the right-hand side where background doesn't fully extend to the edge.
  2. Bring back the sim toolbar, but probably remove "debug" from it.
  3. Make the download bar blend a bit more seamlessly into the page, or remove it.

Numbers 2 and 3 may need some design discussion with the team.

thsparks avatar Jun 21 '23 23:06 thsparks

@abchatra Let me know if you want to include any of those additional changes mentioned above in the hotfix, or if the partial fix is sufficient. Personally, I'd be inclined to leave them for a future release.

thsparks avatar Jun 22 '23 00:06 thsparks

Partial fix is sufficient. Lets hotfix it in microbit as well as arcade

abchatra avatar Jun 22 '23 05:06 abchatra

Removing milestone as it's fixed, but leaving issue as there are follow up improvements we want to do remaining

jwunderl avatar Jun 27 '23 17:06 jwunderl

Lets close this and open new issue for other pending things if it is important.

abchatra avatar Jun 28 '23 03:06 abchatra