Added Electric guitar using Microbit project documentation in docs

[akshitagupta15june]

issue #4818

Project using micro:bit

->Added code.md as well as make.md

->A youtube video for final project

[ghost]

All CLA requirements met.

[akshitagupta15june]

@riknoll @jwunderl please review

[akshitagupta15june]

@ganicke please review

[ganicke]

@akshitagupta15june - Sorry that I didn't see the earlier review request. I'll will take a look at it tomorrow.

[ganicke]

I've put your pages under electric-guitar. We'll need to remove the duplicates in the other folder named Microbit-Electric-Guitar. Also, I've referenced images for the Make under the static path. You'll need to add those images to your branch.

Commit these actions to your branch to complete the Electric Guitar project:

Step 1

Please add these images in a folder created at: ./docs/static/mb/projects/electric-guitar

connections.jpg

guitar-board1.jpg

guitar-board2.jpg

Step 2

Remove the files, and the folder itself, at Microbit-Electric-Guitar.

[akshitagupta15june]

Thankyou so much @ganicke for reviewing, I have made the required changes.

[ganicke]

@akshitagupta15june - We don't need a readme.md with the images so I removed that. Also, MakeCode docs aren't intended to be browsed on GitHub. They are served from a different service backend. So, we don't use the path prefix of ./docs for links as you might expect.

Hey, are you good at art? We'll need a thumbnail image to put in a 'card' for your project in the home screen gallery:

It can be drawn in the same "comic" style as the other Music projects. The image is uploaded just to ./docs/static/mb/projects folder. See ./docs/projects/music.md for reference. Your project will go in as the fourth entry in the gallery list.

Thanks!

[akshitagupta15june]

So i will make a icon for it but do i have to add the image in docs/static/mb/projects or just have to send here

[akshitagupta15june]

Hey @ganicke so I tried making a doodle just like what my electric guitar look like

[akshitagupta15june]

let me know if anything more is required for this pr! @ganicke

[ganicke]

@akshitagupta15june - now, if you can upload this image and save it to your branch as ./docs/static/mb/projects/electric-guitar.png (it's skewed some since we need it as a 300x200 thumbnail), we can finish and publish this project. Thanks.

[akshitagupta15june]

@ganicke done!

Thankyou

[akshitagupta15june]

@ganicke i also updated the code.md because it had make.md link as /docs/projects---->/projects/electric-guitar

[akshitagupta15june]

Thankyou so much @ganicke for approving my pull request, its my first pr in microsoft repo, I would like to contribute more projects in this repo in future.

[ganicke]

@akshitagupta15june - you might experiment with the new play sound block and see if that might give even more realism to the guitar sounds.

[akshitagupta15june]

cool! I will see to it thanks!

[akshitagupta15june]

hey @ganicke the picture is not visible

here is the changes that i have made can help https://github.com/microsoft/pxt-microbit/pull/4856

actually the path you gave in music.md is /static/mb/projects/electric-guitar.png but the image is inside /static/mb/projects/electric-guitar/electric-guitar.png

[ganicke]

@akshitagupta15june - correct. I need the PNG in the folder specified in comment: https://github.com/microsoft/pxt-microbit/pull/4819#issuecomment-1247335581