pxt-microbit icon indicating copy to clipboard operation
pxt-microbit copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Extension: Add Joy-IT RFID mfrc522

Open microbit-pauline opened this issue 2 years ago • 2 comments

Add Joy-IT RFID mfrc522 extension

microbit-pauline avatar Jul 11 '22 14:07 microbit-pauline

Hello @abchatra, could you please have a look at approving this? ( I cannot add a reviewer)

microbit-pauline avatar Jul 11 '22 14:07 microbit-pauline

@abchatra Not sure about the tutorial approvals workflow, but just to let you you know that https://joy-it.net/files/files/Produkte/SBC-RFID-RC522/SBC-RFID-RC522-Manual-09-06-2020.pdf has been submitted for a tutorial for approval, can it be covered for approval in this PR?

microbit-pauline avatar Jul 12 '22 11:07 microbit-pauline

Any updates on this? The linked PDF is the manual to our product. We will update this with the Micro:Bit part as soon as the extension is approved and publicly available.

joy-it avatar Sep 27 '22 07:09 joy-it

@microbit-carlos can you please do the first round of approval with updating target.config. If you are not the right person let me know.

abchatra avatar Sep 28 '22 04:09 abchatra

@abchatra, @carlosperate has given me access to sort this out.

martinwork avatar Sep 28 '22 09:09 martinwork

@abchatra @jwunderl @joy-it Done: https://github.com/microsoft/pxt-microbit/pull/4809/commits/f2db9b0e6ff6e6717ad4842b1143b4cc57ff48b7

martinwork avatar Sep 28 '22 10:09 martinwork

@microbit-carlos I suspect this was added to preferredRepos by mistake. Should it be moved to approvedRepos?

martinwork avatar Sep 28 '22 10:09 martinwork

I have removed it from preferredrepo list.

Going ahead it is sufficient to approvedRepoLib section. Ignore older sections, they are not used anymore.

abchatra avatar Sep 28 '22 17:09 abchatra

Going ahead it is sufficient to approvedRepoLib section. Ignore older sections, they are not used anymore.

Thanks @abchatra !

martinwork avatar Sep 28 '22 17:09 martinwork

I still cannot find the extension in the makecode extension browser. Is something missing here?

joy-it avatar Oct 11 '22 08:10 joy-it

I do see under "individual sensors" image

What keyword are you searching?

abchatra avatar Oct 12 '22 04:10 abchatra

I tried "Joy-IT" (that where we usually find all our extensions) as well as "mfrc522" and "ads1115" but they dont appear with those keywords.

joy-it avatar Oct 12 '22 07:10 joy-it

@joy-it Sorry, using the tag "Individual sensors" was a mistake. I don't know why I did that! https://github.com/microsoft/pxt-microbit/blob/master/targetconfig.json#L769 https://github.com/microsoft/pxt-microbit/blob/master/targetconfig.json#L772 I guess it should be "Science"?

@abchatra Will correcting the tag make them appear when searched for with "Joy-IT", "mfrc522" and "ads1115"? Or do they need to be in "approvedRepos" as well as "approvedRepoLib"?

martinwork avatar Oct 12 '22 11:10 martinwork

I don't think so that is the issue. @joy-it can you add the keywords to the description of your repo?

abchatra avatar Oct 12 '22 21:10 abchatra

I think this is a bug in our backend. Let me take a look

abchatra avatar Oct 12 '22 21:10 abchatra

Where exactly should I add the keywords? I never used keywords in any extension before and never had a problem finding them.

joy-it avatar Oct 24 '22 07:10 joy-it

Sorry for my earlier keyword comment, this is not an issue on your end. Our backend has a bug which we are in the process for fixing. You don't need to do anything, other than wait for the bug to be fixed.

abchatra avatar Oct 24 '22 16:10 abchatra

@abchatra Should I make a PR to change "Individual sensors" to "Science"?

martinwork avatar Oct 24 '22 18:10 martinwork

If it makes sense please do. That is not the issue here though. We have a bug in backend which is not allowing new extensions to be searchable.

abchatra avatar Oct 24 '22 21:10 abchatra