pxt-microbit icon indicating copy to clipboard operation
pxt-microbit copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Extension: Joy-IT ads115

Open microbit-pauline opened this issue 2 years ago • 2 comments

Approval for extension for Joy-IT ads1115

microbit-pauline avatar Jul 07 '22 13:07 microbit-pauline

CLA assistant check
All CLA requirements met.

ghost avatar Jul 07 '22 13:07 ghost

@abchatra Can the tutorial for this extension, https://joy-it.net/files/files/Produkte/COM-KY053ADC/COM-KY053ADC_Manual_2021-01-20.pdf also be approved as part of this extension approval please.

microbit-pauline avatar Jul 12 '22 11:07 microbit-pauline

@abchatra Merged master, added to approvedRepoLib, and removed from preferredRepos.

martinwork avatar Sep 28 '22 17:09 martinwork

@joy-it Looks good overall. I few comments below. I am merging this as they are not blocking comments. Something to improve on.

  1. Can you reduce the size of the icon.png to less than 100kb? These tend to add up in our extension view.
  2. May be better to add kid friendly name for the category instead of ADS1115? Also kid friendly name for some of the API options. image

abchatra avatar Sep 28 '22 18:09 abchatra

Thank you! We now reduced the file size of the icon.png. Will also rework on the category name and the API options.

joy-it avatar Sep 29 '22 07:09 joy-it