pxt-microbit icon indicating copy to clipboard operation
pxt-microbit copied to clipboard

Extension: add iot cloud kit

Open microbit-mark opened this issue 2 years ago • 2 comments

cc @tangjie133

microbit-mark avatar Apr 25 '22 10:04 microbit-mark

@microbit-mark can you update this PR with the changes at 2 places as in this PR https://github.com/microsoft/pxt-microbit/pull/4603/files ?

We need 2 changes before of target.config changes which are live for both /beta & live.

abchatra avatar May 27 '22 23:05 abchatra

@abchatra this branch was created by Mark in the microsoft/pxt-microbit repo and I don't think anybody else in the foundation has write access. Could you rebase and merge on your end?

microbit-carlos avatar Jul 04 '22 13:07 microbit-carlos

@carlosperate now that you have appropriate actions, could you please do the rebase please?

jaustin avatar Aug 18 '22 14:08 jaustin

Rebased and entry added to approvedRepoLib as well.

microbit-carlos avatar Aug 18 '22 15:08 microbit-carlos

@jwunderl I think that's a good point. Are there currently any tools in MakeCode to create things that are redacted during sharing? We'd previously discussed with @abchatra a kinda of "secrets" or "settings" part of the program that was stored separately, but as far as I saw from our side we didn't anywhere beyond the feeling that this was possibly necessary for this sort of program.

As far as the use-case here goes, I think one way I can see to avoid secrets going into the program is to do something like create a serial-based password request block, that the user then has to type their password over serial. However, MakeCode serial looks one-way at the moment?

jaustin avatar Aug 25 '22 08:08 jaustin

Good point @jwunderl I have filed an issue to track this: https://github.com/microsoft/pxt-microbit/issues/4841

There is no alternate way for IOT extensions today. I am going to approve this based on precedence (we have approved this in the past). Even though a bit risky, shared URL are private and I hope it is not shared with everyone if it includes password.

Once we have the feature in the next release, we can retroactively fix these extensions.

abchatra avatar Aug 31 '22 22:08 abchatra