pxt-arcade icon indicating copy to clipboard operation
pxt-arcade copied to clipboard

Embeddable thumbnails (popping open to videos/images)

Open kiki-lee opened this issue 3 years ago • 5 comments

What are the requirements for the project?

We need a way to share big (full-screen-ish?) images and videos, but have them also fit inline in instructions when not being scrutinized.

Is there a deadline or date this is needed by?

ASAP

Please share any existing references, screenshots, links, etc. here that will help us better understand your requirements

image This is what we have now (for better or worse) it shows the entire image scaled to the same width as the instruction panel (with no ability to pop it out or make it full-size).

kiki-lee avatar Feb 08 '22 02:02 kiki-lee

#5 in Kiki's top 10; low effort?

How does this work with block discoverability? How does it work with the onboarding pattern?

A flexible way to show video and additional information about the task at hand. Could also include "just in time" hints.

https://github.com/microsoft/pxt-arcade/issues/4555 - see related issue.

BeckHaru avatar Feb 08 '22 22:02 BeckHaru

Just to make sure. The only requirement here is to create a lightbox of the item you clicked. This isn't a gallery, so gallery type features like next/previous and thumbnail views inside of the lightbox are not necessary.

If that is the case, then we might just go with a super basic lightbox similar to this. https://codepen.io/ongtiffany/pen/BoOeQV. Design on the way.

unthinkmedia avatar Feb 15 '22 13:02 unthinkmedia

@kiki-lee and @BeckHaru let me know if this solution suffices, or if we need something more robust. Given the description this should be enough.

https://www.figma.com/proto/cM4bzz8BcqS6HAnezmSejY/Lightbox?page-id=0%3A1&node-id=2%3A3&viewport=315%2C48%2C0.37&scaling=min-zoom&starting-point-node-id=2%3A3

unthinkmedia avatar Feb 15 '22 14:02 unthinkmedia

Lucas added video support.

abchatra avatar Sep 28 '22 02:09 abchatra

This ticket isn't for the ability to add videos and images, it's for the ability to take small videos and images in the instructions and pop them out so they can be seen more easily.

We do now have the ability to do that with videos in azure (I think), but we still need the ability to do it with anigifs and videos from YouTube.

kiki-lee avatar Sep 28 '22 16:09 kiki-lee