pxt-arcade icon indicating copy to clipboard operation
pxt-arcade copied to clipboard

Link is no linkage in "Docs"

Open Helen09 opened this issue 5 years ago • 6 comments

Describe the bug Link is no linkage in "Docs"

Steps to reproduce the behavior

  1. Navigate to https://arcade.makecode.com/beta#editor
  2. Click "Help" -> "Docs" -> "Game Design Concepts" -> "Walking Hero"
  3. Open link "Open this tutorial in the editor!"

Expect behavior Link should not be no linkage

Actual behavior Link is no linkage in "Docs" issue82801

Additional context

  1. OS: Windows (rs6)
  2. arcade version: 0.14.4
  3. Microsoft MakeCode version: 5.21.6

Helen09 avatar Aug 28 '19 09:08 Helen09

This is an issue in production (0.12.17), as well, and not just in beta.

Does this MD syntax work here to force the link to open in a new window? (It's technically kramdown syntax.)

[link](url){:target="_blank"}

alex-kulcsar avatar Aug 29 '19 17:08 alex-kulcsar

@jwunderl - Link re-writing for sidedocs seems broken for these linkouts in the tutorials?

image

ganicke avatar Sep 04 '19 21:09 ganicke

Yeah that's wroong, though I don't think it would open properly even if it didn't mangle the url (would probably try and open within the iframe and just fail)

Should be reasonable to support the tutorial format specifically and just open in another window?

jwunderl avatar Sep 04 '19 23:09 jwunderl

Can't break out of sidedocs without opening a new window?

ganicke avatar Sep 05 '19 05:09 ganicke

We need a way to restrict rendering of some stuff when in sidedocs vs. full page view.

ganicke avatar Sep 05 '19 05:09 ganicke

Still repros.

abchatra avatar Oct 14 '22 18:10 abchatra