promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

Add missing os import

Open vsantele opened this issue 5 months ago • 14 comments

Description

Fixes #4042, Fixes #4047

PR #4013 forgot to import os in static_web_blueprint.py

All Promptflow Contribution checklist:

  • [x] The pull request does not introduce [breaking changes].
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.
  • [x] I confirm that all new dependencies are compatible with the MIT license.
  • [x] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

vsantele avatar Jul 22 '25 11:07 vsantele

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Aug 19 '25 21:08 github-actions[bot]

latest version of the library in pip fails to execute due to this error.

igarioshka avatar Aug 21 '25 09:08 igarioshka

Hi @igarioshka, To avoid this error, you can pin promptflow to the version 1.18.0.

The only diff is the change that introduces this bug with the missing import: https://github.com/microsoft/promptflow/compare/release/promptflow/1.18.0...release/promptflow/1.18.1

Don't wait for this PR to be merged.

vsantele avatar Aug 21 '25 09:08 vsantele

@vsantele, we have downgraded the version, it's just that I'd really want this PR to be merged, I have left a comment to show github automation that there is activity. :) It baffles me that this issue should've been caught by a simple linter but was not. Coming from a compiled language - this would be a compile time error, but all the checks and workflows that are configured in this repository did not catch that import error.

igarioshka avatar Aug 21 '25 09:08 igarioshka

Promptflow has not received much attention for at least a year.

On the Azure AI Foundry Discord server, they mentioned a deprecation plan for Promptflow, but without any ETA yet.

This is not the right time to start a Promptflow project. I have personally started migrating to the semantic kernel.

vsantele avatar Aug 21 '25 09:08 vsantele

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Sep 05 '25 21:09 github-actions[bot]

Up

vsantele avatar Sep 06 '25 07:09 vsantele

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Sep 21 '25 21:09 github-actions[bot]

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Oct 06 '25 21:10 github-actions[bot]

This pr is still waiting to be reviewed

vsantele avatar Oct 07 '25 16:10 vsantele

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Oct 22 '25 21:10 github-actions[bot]

Up

vsantele avatar Oct 23 '25 19:10 vsantele

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Nov 06 '25 21:11 github-actions[bot]

Up

vsantele avatar Nov 06 '25 23:11 vsantele

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Nov 21 '25 21:11 github-actions[bot]

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Nov 29 '25 21:11 github-actions[bot]